Conversation
dblia
approved these changes
Apr 13, 2021
dblia
left a comment
dblia
left a comment
There was a problem hiding this comment.
Θα ήθελα πολύ να σου πω να φτιάξεις και το travis build αλλά ααααντε.
This code path used to break for IPv6 addresses with `SocketError (getaddrinfo: Address family for hostname not supported)` because it was using `Socket::AF_INET` for every input. This is related to a JRuby bug[1] that is marked as `wontfix`. With the new implementation the address family is being retrieved by `Socket.getaddrinfo` and supports both IPv4 and IPv6 addresses. [1]: jruby/jruby#5112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code path used to break for IPv6 addresses with
SocketError (getaddrinfo: Address family for hostname not supported)because it was using
Socket::AF_INETfor every input.This is related to a JRuby bug1 that is marked as
wontfix.With the new implementation the address family is being retrieved by
Socket.getaddrinfoand supports both IPv4 and IPv6 addresses.Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/